Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOO views requested shipments #3324

Merged
merged 13 commits into from Jan 17, 2020
Merged

Conversation

@ralren
Copy link
Contributor

ralren commented Jan 13, 2020

Description

Added a table view of MTO shipments in TOO view.
Also added a new column called shipment_type to mto_shipments

Setup

make server_run
make office_client_run

Check http://officelocal:3000/too/customer-moves/6fca843a-a87e-4752-b454-0fac67aa4988/customer/6ac40a00-e762-4f5f-b08d-3ea72a8e4b63

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Jira acceptance criteria been met for this change?

References

Screenshots

Screen Shot 2020-01-13 at 1 19 15 PM

);

ALTER TABLE mto_shipments
ADD COLUMN shipment_type mto_shipment_type;

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Jan 13, 2020

Contributor

Does this allow null? Or does it need a default?

This comment has been minimized.

Copy link
@ralren

ralren Jan 13, 2020

Author Contributor

Good catch. I do think it needs a default.

Copy link
Contributor

chrisgilmerproj left a comment

🚀 - Approving the DB changes.

Copy link
Contributor

jim left a comment

Overall this looks good, but I think we need to standardize the enum values before merging.

pkg/handlers/ghcapi/mto_shipments.go Outdated Show resolved Hide resolved
pkg/models/mto_shipments.go Outdated Show resolved Hide resolved
@jim
jim approved these changes Jan 17, 2020
@ralren ralren merged commit 0cbd419 into master Jan 17, 2020
16 checks passed
16 checks passed
auto-approve dependabot PRs
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@ralren ralren deleted the ren-MB-1052-too-views-requested-shipments branch Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.