Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get aws-vault compiling on macOS Catalina #3451

Merged
merged 1 commit into from Feb 3, 2020
Merged

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Feb 3, 2020

There have been some deprecation warnings ever since folks upgraded to macOS Catalina. They looked like:

cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here

These were fixed here:

With this addition the warnings should go away.

@chrisgilmerproj chrisgilmerproj requested review from jacquelineIO, tinyels, Ryan-Koch, chrisrcoles and transcom/truss-infra Feb 3, 2020
@chrisgilmerproj chrisgilmerproj self-assigned this Feb 3, 2020
@chrisgilmerproj chrisgilmerproj requested a review from ntwyman Feb 3, 2020
@mr337
mr337 approved these changes Feb 3, 2020
Copy link
Contributor

mr337 left a comment

On Catalina been running the sever with no issues.

@chrisgilmerproj chrisgilmerproj merged commit 5735473 into master Feb 3, 2020
17 checks passed
17 checks passed
run go mod tidy and updated
Details
auto-approve dependabot PRs
Details
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_compile_catalina branch Feb 3, 2020
@jim

This comment has been minimized.

Copy link
Contributor

jim commented Feb 6, 2020

Thanks for fixing this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.