Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

els fix secure migration script #3464

Merged
merged 1 commit into from Feb 6, 2020
Merged

els fix secure migration script #3464

merged 1 commit into from Feb 6, 2020

Conversation

@tinyels
Copy link
Contributor

tinyels commented Feb 4, 2020

Description

download-secure-migrations, upload-secure-migrations, and update-s3-sql-files were still testing for the ppp-infra version of aws-vault but that is no longer needed. This PR removes those checks.

to test:

  1. follow the steps in Secure Migrations to create and upload a secure migration to at least one environment
  2. use download-secure-migrations to download that file

open questions

should we just delete update-s3-sql-files since it is not supposed to be run more than once on an environment?

@tinyels tinyels requested a review from chrisgilmerproj Feb 6, 2020
@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Feb 6, 2020

should we just delete update-s3-sql-files since it is not supposed to be run more than once on an environment?

Not yet. Probably we should check manually that the files are named correctly.

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@tinyels tinyels merged commit 24df397 into master Feb 6, 2020
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@tinyels tinyels deleted the els_fix_secure_migration branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.