Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

els update user management how to and milmove code migration code generators #3473

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@tinyels
Copy link
Contributor

tinyels commented Feb 5, 2020

update documentation and milmove gen code to ensure we use admin console for user management when we can

Description

We no longer should write migrations to add office and admin users, since we want the audit trail that is provided in the admin console for these actions. I've updated the documents to reflect that and removed the tooling for creating a migration.

Reviewer Notes

I would like to remove the tool for disabling a user, but discovered that we cannot disable milmove users from the admin console. We also might want to be able to manage the DPS users through the admin console as well.

…ole for user management when we can
Copy link
Contributor

reggieriser left a comment

Nice updates. LGTM! 👍

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@tinyels tinyels merged commit ca2ca39 into master Feb 5, 2020
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the els_update_user_management_how_to branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.