Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
MB-1421 - new migrations layout #3496
To support Orders as its own service a new set of migration files will need to be set up. This PR attempts to put the migrations into namespaced folders.
make db_dev_reset db_dev_migrate
Code Review Verification Steps
tinyels left a comment
The concept of "local secure migration" is unclear to me. Is this something we are introducing here, or is it just a new phrase for the placeholder stubs we would use before? I worry that calling them secure will lead engineers to think they should be committing migrations with real data in them.
The nomenclature we're using is really confusing folks. To say "put a local migration here but a secure migration somewhere else" seems to give folks, especially new folks, the wrong impression. What they are actually doing is putting in a stub for a secure migration locally and a secure migration in S3. So a "local secure migration" is more accurate than not acknowledging the local migration is in fact tied to a secure migration. You can't have one without the other so hopefully this fixes things.