Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teardown to tests #3511

Merged
merged 4 commits into from Feb 11, 2020
Merged

Add teardown to tests #3511

merged 4 commits into from Feb 11, 2020

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Feb 11, 2020

Description

What's happening here is that the tests aren't being cleaned up. This leaves the DB running for those tests which in turn eats up memory. Then the golang builder doesn't have the necessary resources to build each binary before testing and we end up with random failures, even on tests that properly tear down.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor Author

chrisgilmerproj commented Feb 11, 2020

@chrisgilmerproj chrisgilmerproj self-assigned this Feb 11, 2020
@chrisgilmerproj chrisgilmerproj requested review from garrettqmartin8, harshamurthy, reggieriser and transcom/truss-infra Feb 11, 2020
@chrisgilmerproj chrisgilmerproj marked this pull request as ready for review Feb 11, 2020
@chrisgilmerproj chrisgilmerproj requested a review from tinyels Feb 11, 2020
@chrisgilmerproj chrisgilmerproj merged commit 72d18d9 into master Feb 11, 2020
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@chrisgilmerproj chrisgilmerproj deleted the cg_teardown_tests branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.