Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circleci-docker-primary image to point to most recent #3524

Merged
merged 3 commits into from Feb 12, 2020

Conversation

@LeDeep
Copy link
Contributor

LeDeep commented Feb 12, 2020

Points to the most recent trussworks/circleci-docker-primary.

@LeDeep LeDeep requested review from reggieriser, chrisgilmerproj and mr337 Feb 12, 2020
@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Feb 12, 2020

Did you run make e2e_test_docker locally? Just want to make sure that all the Dockerfile.*local files work with the new image.

Copy link
Contributor

reggieriser left a comment

Looks like we need to update this too:

go-version: '1.13.4'

@LeDeep

This comment has been minimized.

Copy link
Contributor Author

LeDeep commented Feb 12, 2020

Did you run make e2e_test_docker locally? Just want to make sure that all the Dockerfile.*local files work with the new image.

I did. All green.

@LeDeep

This comment has been minimized.

Copy link
Contributor Author

LeDeep commented Feb 12, 2020

Looks like we need to update this too:

go-version: '1.13.4'

nice catch! pushed update

@reggieriser

This comment has been minimized.

Copy link
Contributor

reggieriser commented Feb 12, 2020

I don't see any issues with this if all the tests pass, but you may want an approval from infra too before merging.

@@ -25,7 +25,7 @@ jobs:
- name: setup go
uses: actions/setup-go@v1
with:
go-version: '1.13.4'
go-version: '1.13.7'

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Feb 12, 2020

Contributor

I think we have docs about updating the docker image. We may want to point out in the docs that this also needs updating.

This comment has been minimized.

Copy link
@LeDeep

LeDeep Feb 12, 2020

Author Contributor

It was actually already in the documentation. I moved that step into the Update transcom/mymove repo section. I also updated the documentation to account for the new files that will need to be updated.

The transcom/ppp circleci config passes in latest for the docker image. So, I removed that section from the readme as those steps don't seem relevant anymore.

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@LeDeep LeDeep merged commit 2792db2 into master Feb 12, 2020
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@LeDeep LeDeep deleted the update-circleci-docker-primary-image branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.