Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migration to support rd's cac card #3526

Merged
merged 4 commits into from Feb 13, 2020
Merged

Conversation

@rdhariwal
Copy link
Contributor

rdhariwal commented Feb 12, 2020

Description

This PR will add my cac card to local, staging and experimental environments.

References

@rdhariwal rdhariwal requested review from chrisgilmerproj and mr337 Feb 12, 2020
@rdhariwal rdhariwal marked this pull request as ready for review Feb 12, 2020
Copy link
Contributor

chrisgilmerproj left a comment

We need to fix the CN on your uploaded migrations.

…d EPIDI value and only local environment should have github username instead
@rdhariwal

This comment has been minimized.

Copy link
Contributor Author

rdhariwal commented Feb 12, 2020

We need to fix the CN on your uploaded migrations.

Done, one more pass please @chrisgilmerproj

Copy link
Contributor

chrisgilmerproj left a comment

I have one suggestion for the docs but otherwise everything appears in order.

Co-Authored-By: Chris Gilmer <chris@truss.works>
Copy link
Contributor

chrisgilmerproj left a comment

🚀

@rdhariwal rdhariwal merged commit 18d2b70 into master Feb 13, 2020
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@rdhariwal rdhariwal deleted the rd-cac-cert-migrate-mb-1503 branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.