Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths for database codeowners #3528

Merged
merged 2 commits into from Feb 12, 2020
Merged

Fix paths for database codeowners #3528

merged 2 commits into from Feb 12, 2020

Conversation

@reggieriser
Copy link
Contributor

reggieriser commented Feb 12, 2020

Description

Automatic assignment of codeowners appears to have broken when we restructured the migrations folder. This is an attempt to fix the paths.

I tried to test this in PR #3527 but couldn't seem to make it trigger the codeowners on the branch. So maybe it needs to be in master first?

Here's an example from the GitHub docs that seems along the lines of what we're wanting, so I've modeled my changes after it.

# In this example, @doctocat owns any files in the build/logs
# directory at the root of the repository and any of its
# subdirectories.
/build/logs/ @doctocat
Copy link
Contributor

tinyels left a comment

Thanks for catching this!

Copy link
Contributor

lynzt left a comment

we should prob remove jim...
and double check he's removed from other places in this file...

@reggieriser

This comment has been minimized.

Copy link
Contributor Author

reggieriser commented Feb 12, 2020

@lynzt, Good catch! I didn't even think to examine the list of names. I've pushed a fix.

@lynzt
lynzt approved these changes Feb 12, 2020
Copy link
Contributor

lynzt left a comment

🚢


# we also want to make sure the local migrations are not doing schema changes
/local_migrations/* @chrisgilmerproj @tinyels @garrettqmartin8 @gidjin @lynzt @reggieriser @rdhariwal @Ryan-Koch @jim @chrisrcoles
/migrations/ @chrisgilmerproj @tinyels @garrettqmartin8 @gidjin @lynzt @reggieriser @rdhariwal @Ryan-Koch @chrisrcoles

This comment has been minimized.

Copy link
@chrisgilmerproj

chrisgilmerproj Feb 12, 2020

Contributor
Suggested change
/migrations/ @chrisgilmerproj @tinyels @garrettqmartin8 @gidjin @lynzt @reggieriser @rdhariwal @Ryan-Koch @chrisrcoles
/migrations/** @chrisgilmerproj @tinyels @garrettqmartin8 @gidjin @lynzt @reggieriser @rdhariwal @Ryan-Koch @chrisrcoles

This comment has been minimized.

Copy link
@reggieriser

reggieriser Feb 12, 2020

Author Contributor

We can try that next if the syntax I'm using here doesn't work. See my note in the PR description -- what I'm doing in theory matches the CODEOWNERS docs example (neither worked on my test PR, so hard to know for sure).

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@reggieriser reggieriser merged commit 73cd172 into master Feb 12, 2020
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@reggieriser reggieriser deleted the rr-fix-db-codeowners branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.