Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables file for send payment reminder ECS scheduled task #3543

Merged
merged 2 commits into from Feb 14, 2020

Conversation

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj commented Feb 14, 2020

Description

We forgot to add in the env files required for the deploy. And since the script was configured to expect the file to already exist the error was swallowed by the variable and not printed to the screen. The script is changed here to provide better error checking and debug output for folks deploying. It also prints the full task definition so folks can view it in advance.

This was tested by deploying directly to staging.

@chrisgilmerproj chrisgilmerproj requested review from lynzt, garrettqmartin8, harshamurthy and transcom/truss-infra Feb 14, 2020
@chrisgilmerproj chrisgilmerproj self-assigned this Feb 14, 2020
@lynzt
lynzt approved these changes Feb 14, 2020
Copy link
Contributor

lynzt left a comment

this worked when testing... 🚢

@lynzt lynzt merged commit a174b59 into master Feb 14, 2020
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.