voxels_test: replace cvcapp singleton with fixture-local cvc::app#12
Merged
Conversation
The test fixture already exposes a local cvc::app member named `ctx`; six call sites in the threading tests still used the cvcapp singleton. Replace cvcapp.X(...) with ctx.X(...) so the threading tests exercise the same per-fixture app the data flows through. Linux Debug build clean; ctest -R VoxelsTest 108/108 passed. Part of cvc-singleton-removal-plan.md (PR 8 — voxels piece).
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six call sites in
voxels_test.cpp's threading tests used thecvcappsingleton even though the test fixture exposes a localcvc::app ctxmember. Replacecvcapp.X(...)withctx.X(...)so the threading exercises the same per-fixture app the rest of the test uses.Validation
ctest -R VoxelsTest -j4: 108/108 passedPart of cvc-singleton-removal-plan.md (PR 8, voxels piece).
Independent of #11; can land in any order.