Skip to content

voxels_test: replace cvcapp singleton with fixture-local cvc::app #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
transfix merged 1 commit into from
May 2, 2026
Merged

voxels_test: replace cvcapp singleton with fixture-local cvc::app #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/cvc/tests/voxels_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3250,14 +3250,14 @@ TEST_F(VoxelsCUDATest, MultithreadedCUDAOperations) {
std::vector<std::string> task_keys;

// Set pool size
unsigned int original_pool_size = cvcapp.getThreadPoolSize();
cvcapp.setThreadPoolSize(std::min(4u, boost::thread::hardware_concurrency()));
unsigned int original_pool_size = ctx.getThreadPoolSize();
ctx.setThreadPoolSize(std::min(4u, boost::thread::hardware_concurrency()));

for (int t = 0; t < num_threads; t++) {
std::string key = "cuda_voxels_" + std::to_string(t);
task_keys.push_back(key);

cvcapp.startThreadPooled(
ctx.startThreadPooled(
key,
[this, t, &success_count, dim]() {
try {
Expand Down Expand Up @@ -3289,15 +3289,15 @@ TEST_F(VoxelsCUDATest, MultithreadedCUDAOperations) {

// Wait for all tasks to complete
for (const auto &key : task_keys) {
if (cvcapp.hasThread(key)) {
thread_ptr tptr = cvcapp.threads(key);
if (ctx.hasThread(key)) {
thread_ptr tptr = ctx.threads(key);
if (tptr)
tptr->join();
}
}

// Restore original pool size
cvcapp.setThreadPoolSize(original_pool_size);
ctx.setThreadPoolSize(original_pool_size);

EXPECT_EQ(success_count.load(), num_threads);
}
Expand Down
Loading