Show reviewed stats #23

Merged
merged 4 commits into from May 14, 2012

Conversation

Projects
None yet
3 participants
Contributor

rtnpro commented Apr 17, 2012

This changeset shows reviewed stats in resource details and resource actions pages for translation languages.

Contributor

jkal commented Apr 17, 2012

An alternative would be to just calculate the reviewed stats in _aggregate_rlstats() and avoid that check in calculate_stats().

It's not information we need on the overview page right now but it seems to me a cleaner way to do it.

Contributor

rtnpro commented Apr 26, 2012

@jkal

I have one question. The languages in the project overview page is strongly coupled with RLStats. For a new project with no resource, when new language teams are added, they don't show up at all in the overview page.

Is this a feature or a bug?

Contributor

rtnpro commented May 1, 2012

@jkal

This is ready to be merged to devel. Fixed some regressions and all related tests running successfully.

Contributor

mpessas commented May 14, 2012

Regarding the context variables you return from the templatetag, why not keep the logic inside the templatetag and instead return a simple is_translation and the reviewed variables.

rtnpro added some commits Apr 16, 2012

Show reviewed stats in resource details and resource actions pages.
--HG--
extra : rebase_source : e2dfe53a66379aaa86c03d7a56e463586dab140b
Don't show reviewed stats in resource actions page for resource.sourc…
…e_language.

--HG--
extra : rebase_source : f77fc3ae05a732dcf273ecb559fb0ccdbec8101a
Fixed template error in project overview page while displaying stats …
…bars.

--HG--
extra : rebase_source : 0a025ed80a9b332492bfb7a40449d9b094f9e422
Contributor

rtnpro commented May 14, 2012

@mpessas

I removed the logic from the templates. I think it's ready.

mpessas added a commit that referenced this pull request May 14, 2012

Merge pull request #23 from transifex/show_reviewed_stats
Show reviewed statistics in resource pages.

@mpessas mpessas merged commit 29484b0 into devel May 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment