Allow anonymous access to files. #73

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

sayanchowdhury commented May 10, 2012

This will allow the anonymous users to pull translations from transifex.net.

Please review it.

Thanks,
Regards,
sayanchowdhury

Contributor

mpessas commented May 14, 2012

Have you checked what happens, when someone is trying to access anonymously the files of a private project?

Contributor

sayanchowdhury commented May 14, 2012

@mpessas

Yes, I checked it, whenever one tries to access anonymously the files of a private project it shows "Forbidden Access"

Contributor

mpessas commented May 15, 2012

Great! Now, when the anonymous access is allowed in the API, too, we can merge this pull request.

Contributor

sayanchowdhury commented Jun 4, 2012

@mpessas

Wrote the code to allow anonymous access through API. Please review it.

Contributor

rtnpro commented Jun 5, 2012

@sayanchowdhury

Changes look good. I have created a branch on top of this pull request here https://github.com/transifex/transifex/tree/allow_anonymous_access_to_translations_files

I have updated a test for reading translation files here bb83486

Similarly, add tests for POST , PUT, DELETE, etc requests to ensure that anonymous user has no access to them. Also, check for private projects too.

Contributor

rtnpro commented Jun 5, 2012

@sayanchowdhury @mpessas

Closing this pull request here. Pull request reopened at #100.

rtnpro closed this Jun 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment