Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

Dialogs #20

Open
dontpanicgr opened this issue May 21, 2018 · 1 comment
Open

Dialogs #20

dontpanicgr opened this issue May 21, 2018 · 1 comment
Assignees
Labels
txds Core issues regarding Tx Design System ux Covers user experience issues and functionality that needs further research and grooming

Comments

@dontpanicgr
Copy link
Contributor

dontpanicgr commented May 21, 2018

Dialogs

Dialogs inform users about a task and can contain critical information, require decisions, or involve multiple tasks.
Also in this thread some early discussion took place about dialogs and system feedback overall.
#7 (comment)

This issue is posted due to recent ticket about navigating away from a plural string in the editor.

With this txds issue we will try to understand and find an appropriate, modular way to:

  1. Properly inform users on the outcome of an action (e.g. uncompleted work that is not saved and might be lost if navigating away from a component or page in the application.
  2. Provide easy to undestand navigation to confirm or dismiss a proposed action.

Example

Editor: Tab for navigating away from unsaved plural string

Transifex says
You have untranslated plural forms.
Your work will be lost. Are you sure you want to navigate away from this string?
[ Cancel ] [ OK ]

Action Behaviour Keyboard Key Result
Cancel Stay on this page Esc Work not lost
OK Leave this page Enter/Return Work lost

Component

Based on the above examples, we can discuss on the behaviour and structure of the dialog component which could look and work as follows:

Dialog title
You have {{unsaved_work}}.
Your work will be lost. Are you sure you want to {{user_action}}?
[ Cancel ] [ OK ]

Action Behaviour Keyboard Key Result
Cancel Stay on this page Esc Work not lost
OK Leave this page Enter/Return Work lost
Save * Stay on this page ... Save work

* optional


Screens:

screen shot 2018-05-21 at 15 15 31
screen shot 2018-05-21 at 15 16 14


Further reading:

https://material.io/design/components/dialogs.html#actions
https://ux.stackexchange.com/questions/83535/should-an-unsaved-changes-dialog-in-a-web-app-contain-a-save-option
http://designsystem.morningstar.com/components/dialogs.html
https://medium.com/ux-power-tools/design-a-reusable-system-modal-e358985cfeb6

@dontpanicgr dontpanicgr added txds Core issues regarding Tx Design System ux Covers user experience issues and functionality that needs further research and grooming labels May 21, 2018
@dontpanicgr dontpanicgr self-assigned this May 21, 2018
@mikegianno
Copy link
Contributor

The existing dialogue is managed by the browser (if you open a different browser, and replicate actions to preview this dialogue you might see something different).

In that sense, I don't think any work can be done on this dialogue other than the copywriting. We cannot control any aspects of that.

My personal opinion is that this is a typical validation modal that should be totally managed by our system and not the browser. In other instances we have already implemented validation in our system (TM entry deletion in the editor, project deletion, org deletion) AND also revisited from the design perspective.
I believe we should simply sanitize those cases whenever we find them and not introduce more as we are increasing our design debt.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
txds Core issues regarding Tx Design System ux Covers user experience issues and functionality that needs further research and grooming
Projects
None yet
Development

No branches or pull requests

2 participants