From 6ff785b019213783f13980a95de3ff31ed61195c Mon Sep 17 00:00:00 2001 From: Drew Dara-Abrams Date: Fri, 10 Mar 2017 13:21:47 -0800 Subject: [PATCH] when logging exceptions to Sentry, include context closes #1018 --- app/workers/feed_eater_schedule_worker.rb | 9 ++++++++- app/workers/feed_eater_worker.rb | 9 ++++++++- app/workers/feed_fetcher_worker.rb | 8 +++++++- 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/app/workers/feed_eater_schedule_worker.rb b/app/workers/feed_eater_schedule_worker.rb index 1fc9e428e..7c793b042 100644 --- a/app/workers/feed_eater_schedule_worker.rb +++ b/app/workers/feed_eater_schedule_worker.rb @@ -23,7 +23,14 @@ def perform(feed_onestop_id, feed_version_sha1, feed_schedule_import_id, trip_id exception_log = "\n#{e}\n#{e.backtrace}\n" log exception_log, :error feed_schedule_import.failed(exception_log: exception_log) - Raven.capture_exception(e) if defined?(Raven) + if defined?(Raven) + Raven.capture_exception(e, { + tags: { + 'feed_onestop_id' => feed_onestop_id, + 'feed_version_sha1' => feed_version_sha1 + } + }) + end else log "FeedEaterScheduleWorker #{feed_onestop_id}: Saving successful schedule import" feed_schedule_import.succeeded diff --git a/app/workers/feed_eater_worker.rb b/app/workers/feed_eater_worker.rb index 044a27ce6..82852c2f1 100644 --- a/app/workers/feed_eater_worker.rb +++ b/app/workers/feed_eater_worker.rb @@ -48,7 +48,14 @@ def perform(feed_onestop_id, feed_version_sha1=nil, import_level=0) log exception_log, :error log "FeedEaterWorker #{feed_onestop_id}: Saving failed feed import" feed_version_import.failed(exception_log: exception_log) - Raven.capture_exception(e) if defined?(Raven) + if defined?(Raven) + Raven.capture_exception(e, { + tags: { + 'feed_onestop_id' => feed_onestop_id, + 'feed_version_sha1' => feed_version.try(:sha1) + } + }) + end else # Enqueue FeedEaterScheduleWorker jobs, or save successful import. if import_level < 2 diff --git a/app/workers/feed_fetcher_worker.rb b/app/workers/feed_fetcher_worker.rb index 67039923a..0d57ae08a 100644 --- a/app/workers/feed_fetcher_worker.rb +++ b/app/workers/feed_fetcher_worker.rb @@ -19,7 +19,13 @@ def perform(feed_onestop_id) # SignalException, and SyntaxError log e.message, :error log e.backtrace, :error - Raven.capture_exception(e) if defined?(Raven) + if defined?(Raven) + Raven.capture_exception(e, { + tags: { + 'feed_onestop_id' => feed_onestop_id + } + }) + end end end end