Flat XML storage format #3776
This introduces a new monolingual storage format for a flat XML file that may look like this:
<root> <str key="hello_world">Hello World!</str> <str key="new_format">This is the new XML-based format.</str> <str key="flat_structure">It uses a flat structure. Just a root element, and a number of what is basically key/value pairs.</str> <str key="customizable">Names and namespaces can be customized as parameters (so you can use any <root> or <element> name as you like).</str> </root>
Main motivation to add such a format was to use it with Weblate (so CC @nijel in case he wants to chime in on things that might be required for Weblate; such as the mandatory
I'd still consider this WIP, as I could use some feedback/help on the following:
And also: Everything else I didn't think about while implementing this :)
I only gave this PR a quick review, but I have some major blockers:
I must say I am quite pleased to see that the converters are coded using the pattern I am trying to introduce for all the converters in TTK, which should allow for easier maintenance and refactoring of common code.
Rebased on latest master to get the changes in (especially for the tests that now require the
I also added some documentation, taking some inspiration from other documentation pages. I put the format under "translatable documents" next to HTML, since it seemed most fitting (vs. DTD, which would be be more fitting IMO, but is Mozilla-specific).
referenced this pull request
Apr 14, 2018
2 times, most recently
Apr 14, 2018
I'll look into getting them addressed either later today or tomorrow, thanks for getting back to it!
Got the things addressed (and fixed a typo in docs), so I'm ready for some more review (if necessary).
Rebased on latest master and updated the tests to not use the mixed quotes, although #3871 would be a nice addition to use instead of my lazy single-level reindent there.
CI fail seems to be the known (?) segfault, not sure I can do anything about that.