storage: Preserve structured IDs on round trip #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When some item was a string previously and was changed to dict or list, it should be gracefully handled. Fixes WeblateOrg/weblate#4316
3 tasks
nijel
added a commit
that referenced
this pull request
Oct 30, 2020
This is a regression introduced by #4091 as that makes the flat JSON file expand the unit keys. Fixes WeblateOrg/weblate#4779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML and JSON storages now preserve structure on round trip even when it contains strings used in the unit IDs. The structure is kept in separate object and is used when saving.
Fixes #3819
Fixes #3857
Fixes #3541
Supersedes #3835
Built on top of #4090, only last commit is relevant here.