Move Frey specific overrides to group_vars file #11

Merged
merged 2 commits into from Jan 11, 2017

Projects

None yet

2 participants

@tersmitten
Collaborator

For now I put the Frey specific overrides in infra/group_vars/all/Frey.yml, it would be way better if Frey would create this file for us.

Some other variables that should reside here are:

  • ansistrano_allow_anonymous_stats
  • ansistrano_remove_rolled_back

but there are more, see the frey-specific-changes branches of all the forked roles.

@tersmitten tersmitten Add forgotten and misspelled role variables
3c68947
@tersmitten tersmitten self-assigned this Dec 27, 2016
@tersmitten tersmitten requested a review from kvz Dec 27, 2016
@tersmitten tersmitten referenced this pull request in transloadit/infra-imagemagick Dec 27, 2016
Merged

Upgrade Frey to v0.3.27 /cc @tersmitten #3

@kvz
Member
kvz commented Jan 5, 2017

I think this file should reside inside Frey itself, would you agree @tersmitten ?

@tersmitten
Collaborator

I rather have it in Frey (see), since it's the same in multiple repositories.

@tersmitten tersmitten Make it easier to override settings and clear that this is a private …
…file
c5384da
@tersmitten
Collaborator

I'm done

@kvz
Member
kvz commented Jan 11, 2017

Okay so we both agree the vars should go into the Frey repo, and this is just a step towards that? I'll assume yes and merge this already 👍

@kvz kvz merged commit 1c9a355 into master Jan 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kvz kvz deleted the frey-v0.3.27 branch Jan 11, 2017
@kvz kvz referenced this pull request in tus/tusd Jan 11, 2017
Merged

Upgrade Frey to v0.3.27 /cc @tersmitten #85

@tersmitten
Collaborator

Okay so we both agree the vars should go into the Frey repo, and this is just a step towards that? I'll assume yes and merge this already

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment