From 3437074765b70d428357c1053e35ae56abe36850 Mon Sep 17 00:00:00 2001
From: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Sun, 8 Jan 2023 15:32:36 +0100
Subject: [PATCH] ci: make sure Yarn's global cache is disabled (#4268)

Yarn v4 enables global caching by default, using a local cache
simplifies the use of @actions/cache.
Also simplifies the "Publish to the npm registry" step.
---
 .github/workflows/bundlers.yml          | 5 ++++-
 .github/workflows/ci.yml                | 3 +++
 .github/workflows/companion-deploy.yml  | 3 +++
 .github/workflows/companion.yml         | 3 +++
 .github/workflows/e2e.yml               | 3 +++
 .github/workflows/linters.yml           | 3 +++
 .github/workflows/lockile_check.yml     | 3 +++
 .github/workflows/manual-cdn.yml        | 3 +++
 .github/workflows/release-candidate.yml | 3 +++
 .github/workflows/release.yml           | 9 ++++++---
 .github/workflows/website.yml           | 3 +++
 11 files changed, 37 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/bundlers.yml b/.github/workflows/bundlers.yml
index 16078f1fbe..083c44d2f6 100644
--- a/.github/workflows/bundlers.yml
+++ b/.github/workflows/bundlers.yml
@@ -15,9 +15,12 @@ on:
       - '.github/**'
       - '!.github/workflows/bundlers.yml'
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   isolate_uppy:
-    name: Isolate Uppy package
+    name: Isolate Uppy packages
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index dbdcfb0538..64eacc573f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -25,6 +25,9 @@ on:
       - '.github/**'
       - '!.github/workflows/ci.yml'
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   unit_tests:
     name: Unit tests
diff --git a/.github/workflows/companion-deploy.yml b/.github/workflows/companion-deploy.yml
index e467ac70a8..c2d676def8 100644
--- a/.github/workflows/companion-deploy.yml
+++ b/.github/workflows/companion-deploy.yml
@@ -11,6 +11,9 @@ on:
       - 'packages/@uppy/companion/**'
       - '.github/workflows/companion-deploy.yml'
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   npm:
     name: Generate npm tarball
diff --git a/.github/workflows/companion.yml b/.github/workflows/companion.yml
index 7308700605..915ce06e21 100644
--- a/.github/workflows/companion.yml
+++ b/.github/workflows/companion.yml
@@ -14,6 +14,9 @@ on:
       - 'packages/@uppy/companion/**'
       - '.github/workflows/companion.yml'
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   test:
     name: Unit tests
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index f9c67410e5..20b9c62ea7 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -26,6 +26,9 @@ on:
 
 concurrency: ${{ github.workflow }}--${{ github.ref }}
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   e2e:
     if: ${{ !github.event.pull_request || (contains(github.event.pull_request.labels.*.name, 'safe to test') && github.event.pull_request.state == 'open') || (github.event.pull_request.head.repo.full_name == github.repository && github.event.event_name != 'labeled') }}
diff --git a/.github/workflows/linters.yml b/.github/workflows/linters.yml
index 22a5387644..9a3a5436f4 100644
--- a/.github/workflows/linters.yml
+++ b/.github/workflows/linters.yml
@@ -13,6 +13,9 @@ on:
       - '.github/**'
       - '!.github/workflows/linters.yml'
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   lint_js:
     name: Lint JavaScript/TypeScript
diff --git a/.github/workflows/lockile_check.yml b/.github/workflows/lockile_check.yml
index 57fed09b32..af5c94d9f4 100644
--- a/.github/workflows/lockile_check.yml
+++ b/.github/workflows/lockile_check.yml
@@ -11,6 +11,9 @@ on:
     paths:
       - yarn.lock
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   lint_lockfile:
     name: Lint yarn.lock
diff --git a/.github/workflows/manual-cdn.yml b/.github/workflows/manual-cdn.yml
index a7d0ca048e..c95ab5718b 100644
--- a/.github/workflows/manual-cdn.yml
+++ b/.github/workflows/manual-cdn.yml
@@ -7,6 +7,9 @@ on:
         required: true
         default: "uppy"
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   upload:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/release-candidate.yml b/.github/workflows/release-candidate.yml
index aa67edac17..d5f2bfa2b9 100644
--- a/.github/workflows/release-candidate.yml
+++ b/.github/workflows/release-candidate.yml
@@ -3,6 +3,9 @@ on:
   push:
     branches: release
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   prepare-release:
     name: Prepare release candidate Pull Request
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index aaacea260f..edfa74e560 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -3,6 +3,9 @@ on:
   pull_request_review:
     types: [submitted]
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   release:
     name: Publish releases
@@ -43,10 +46,10 @@ jobs:
         run: corepack yarn run build
       - name: Hack to allow the publish of the Angular package
         run: corepack yarn workspace @uppy/angular prepublishOnly
-      - name: Login to NPM
-        run: corepack yarn config set npmAuthToken ${{ toJSON(secrets.NPM_TOKEN) }}
-      - name: Publish to NPM
+      - name: Publish to the npm registry
         run: corepack yarn workspaces foreach --no-private npm publish --access public --tolerate-republish
+        env:
+          YARN_NPM_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
       - name: Merge PR
         id: merge
         run: |
diff --git a/.github/workflows/website.yml b/.github/workflows/website.yml
index 4c68400c74..bf56238e1e 100644
--- a/.github/workflows/website.yml
+++ b/.github/workflows/website.yml
@@ -9,6 +9,9 @@ on:
       - '.github/workflows/website.yml'
   workflow_dispatch:
 
+env:
+  YARN_ENABLE_GLOBAL_CACHE: false
+
 jobs:
   deploy:
     name: Deploy