Tus withCredentials option missing in TypeScript definition

[szh]

The withCredentials option mentinoed in the docs here: https://uppy.io/docs/tus/#withCredentials-false appears to be missing from the typescript definition file: https://github.com/transloadit/uppy/blob/master/packages/@uppy/tus/types/index.d.ts

As it happens, I don't think this option does anything anymore, though I can't find any record of it being removed. Is there a way to have cookies passed on to the Tus server at this point?

[goto-bus-stop]

I guess it was removed from tus-js-client in the v2 upgrade. That means we had an unintentional backwards compatibility breaking change. We can add it back in @uppy/tus by doing something like this: https://github.com/tus/tus-js-client/blob/446c6a309546730d95396abe6e9728a61d99ee60/docs/api.md#onbeforerequest

[szh]

@goto-bus-stop Thanks for the direction. I added a pull request, #2544

[bedgerotto]

Hi there, I submitted this PR (#2611 ) because I need to customize the onBeforeRequest callback inside the host application and I think this is related with thsi issue.