Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add allowDuplicateFiles option to @uppy/core #1334

Closed
wants to merge 1 commit into from

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Mar 8, 2019

Allow duplicate files to be added to Uppy (optionally). If the fileId exists, we either throw an error, or generate a new unique file id, so that a copy of the file can be added:

screen shot 2019-03-08 at 15 18 09

screen shot 2019-03-08 at 15 17 33

Fixes #843 #1179 #754

Does this break something for Golden Retriever and Tus?

todo:

  • tests
  • docs
  • figure out the default, and whether we want to add an “overwrite” option — current behavior

if fileId exists, we either throw an error, or generate a new unique file id, so that a copy of the file can be added
@goto-bus-stop
Copy link
Contributor

goto-bus-stop commented Mar 18, 2019

tus resume: true would interfere with this at the moment, because it has its own fingerprint generation. it might be ok if we override the fingerprint option and use the Uppy-generated file ID… i think golden retriever may be fine because it already uses the IDs provided by uppy.

this feature does add an entire new axis to think about in every other patch though :D i don't think a native file input supports this and i'm not really sure of the use case?
e; seems like the linked issues are mostly talking about adding the same file after a previous upload, that does make sense.

@arturi arturi changed the title Add allowDuplicateFiles option to @uppy/core [wip] Add allowDuplicateFiles option to @uppy/core Mar 20, 2019
@arturi arturi closed this Apr 15, 2019
@arturi
Copy link
Contributor Author

arturi commented Apr 22, 2019

Closed, because this feature might break some other features, like tus resumability, and requires more thinking through, and we didn’t want unexpected breakage before 1.0 release.

@jvelten
Copy link
Contributor

jvelten commented Jan 17, 2023

Will an option to allowDuplicateFiles released?
We have some use-cases for supervisors they need to upload the same file (path, name, source is equal) into the mediacenter of different users.

@Murderlon Murderlon deleted the feature/core-duplicate-files branch May 24, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make unique generated file id
3 participants