Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design facelift #1442

Merged
merged 88 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@nqst
Copy link
Collaborator

commented Apr 11, 2019

A lot of design improvements inside! Hard to list all of them, but here are some highlights:

  • Much nicer focus styles.
  • Typography polishing
  • Organizing colors in SCSS
  • Nice retry icon
  • Updated play/pause/cancel icons
  • Improve status bar
  • Enlarge clickable areas of Done/Back/+ buttons
  • Remove some buggy animations, but keep important and good ones
  • Updated Dropbox icon
  • Improved Provider views

Screenshots:

image

image

image

image

image

image

@arturi arturi self-requested a review Apr 11, 2019

@arturi

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

Great work, Alex! 🎈 Thank you, I really like most of the changes. We had a call about this, here are some feedback points, so we don’t loose those:

  • dots are misplaced when adding from google drive:

Screen Shot 2019-04-12 at 11 57 51

  • plus + button is too far from the right edge
  • instagram opacity — photo shaking in Firefox, and the effect of fading on all images is not ideal, I feel
  • “Filter” in Google Drive is too grayed out
  • retry button could use a larger padding in Firefox + some line alignment
  • I’d make fonts in Google Drive list a bit larger for accessibility
  • maybe focus on the icons (Instagram, Google Drive, provider selecting screen) could use a bit more contrast
@nqst

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 12, 2019

Thanks for the feedback, Artur 👍 Just fixed everything you listed, please check it out.

@arturi arturi merged commit f4565ef into transloadit:master Apr 12, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@arturi

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

Thank you, merged! 🚀 🎸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.