Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion: send illusive upload progress when multipart downloads are on #1454

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
4 participants
@ifedapoolarewaju
Copy link
Collaborator

commented Apr 17, 2019

Multipart uploads do not happen in parallel with downloads (i.e downloads completes first before upload begins), so to avoid the situation where the user on the client side doesn't see any progress for the long period while the download is happening in Companion, the PR makes companion send illusive progress while the file is initially being downloaded

@kvz

kvz approved these changes Apr 17, 2019

Copy link
Member

left a comment

LGTM!

@goto-bus-stop
Copy link
Member

left a comment

seems good

@kvz kvz merged commit adfb2ae into master Apr 17, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@kvz kvz deleted the multipart-progress branch Apr 17, 2019

@kvz

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

💪 Nice work Ife! 💪

@arturi

This comment has been minimized.

Copy link
Collaborator

commented Apr 22, 2019

Tested:

Screen Shot 2019-04-22 at 17 40 49

uppy: 2019-04-22T14:40:36.039Z [debug] uploader.illusive.progress a282e57b 0 28425609.5 94071969
uppy: 2019-04-22T14:40:36.039Z [debug] uploader.upload.progress a282e57b 28425609.5 94071969 30.22%
uppy: 2019-04-22T14:40:36.042Z [debug] uploader.download.progress a282e57b 56867603 bytes

Thanks, Ife!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.