Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility: focus handling, tweak labels and more #414

Merged
merged 12 commits into from Nov 13, 2017
Merged

Improve accessibility: focus handling, tweak labels and more #414

merged 12 commits into from Nov 13, 2017

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Nov 8, 2017 •
edited

  • trap focus inside Dashboard modal while it’s open
  • switch to trapping focus inside a tab/FileCard when that’s open?
  • remove extra elements from focus via tabindex="-1" or hiding them
  • allow selecting files from remote providers with a keyboard
  • restore focus after modal has been closed

@goto-bus-stop goto-bus-stop mentioned this pull request Nov 9, 2017
Closed
@arturi arturi merged commit 69a21da into master Nov 13, 2017
@arturi arturi changed the title [WIP] Improve accessibility: focus handling, tweak labels and more Improve accessibility: focus handling, tweak labels and more Nov 16, 2017
@goto-bus-stop goto-bus-stop deleted the improvement/a11y branch December 18, 2017 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@arturi