Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmission's symbolic icon doesn’t show up in Flatpak #414

Closed
Obsidien opened this issue Oct 4, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Obsidien
Copy link

commented Oct 4, 2017

I installed Transmission from the Flathub flatpak repository, and the symbolic icon is neither showing up when in HighContrast theme (the one for visually impaired people), nor in GNOME Shell’s topbar; the “colored and detailed” icon is used instead. Could that be fixed upstream?

@mikedld

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

There is no official connection between Transmission project and any kind of Flatpak packages. @wjt or other people in #64 may have a clue.

@mikedld mikedld closed this Nov 30, 2017

@mikedld mikedld added the invalid label Nov 30, 2017

@wjt

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2017

@Obsidien please file issues about the Flathub package here: https://github.com/flathub/com.transmissionbt.Transmission/issues

@wjt wjt referenced this issue Nov 30, 2017

Merged

No symbolic icon #2

wjt added a commit to wjt/transmission that referenced this issue Nov 30, 2017

gtk: add symbolic icon
The -symbolic icon variant (if available) is used in the GNOME top bar,
and when the high contrast theme is in use.  This icon was created by
Jakub Steiner, and comes from the gnome-icons repository:

https://github.com/gnome-design-team/gnome-icons/blob/master/apps-symbolic/Adwaita/scalable/apps/transmission-symbolic.svg
https://bugzilla.redhat.com/show_bug.cgi?id=1221292

There is some confusion over whether symbolic app icons should be
installed to icons/hicolor/scalable/apps (alongside the regular scalable
icon) or to icons/hicolor/symbolic/apps. On the one hand,
https://wiki.gnome.org/Initiatives/GnomeGoals/HighContrastAppIcons has
this to say:

> […] obtain a suitable symbolic style icon […] and install it to the
> hicolor prefix, the same way you would for the full color variant.
>
> cp myapp-symbolic.svg /usr/share/icons/hicolor/scalable/apps/myapp-symbolic.svg

On the other hand, the Fedora package at
https://src.fedoraproject.org/rpms/transmission/blob/master/f/transmission.spec
ships this icon in icons/hicolor/symbolic/apps:

> # Install the symbolic icon
> mkdir -p  %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps
> cp %{SOURCE1} %{buildroot}%{_datadir}/icons/hicolor/symbolic/apps/transmission-symbolic.svg

Anecdotally, icons in scalable/ have minimum size 64×64 on openSUSE, so
symbolic/ is the safer location (given the GNOME top bar uses 32×32
icons). This has the advantage of matching the location used in the
distribution which already ships this file.

transmission#414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.