fix: Add precheck for tar archive test. #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes: Fixed |
Recently we discovered we do not properly handle broken tar archives. The problem is running tar (in linting mode) on invalid archive and piping stdout to NSPipe introduces a hang as NSPipe cannot process such huge data amounts. Fixing this problem by adding a precheck with tar (listing mode) with piping stdout to /dev/null. Fixes: transmission#4702
nevack
force-pushed
the
nevack/fix-macos-tar-hang
branch
from
ae66d3f
to
57da398
Compare
|
Force push with Code Style fix. |
ckerr
approved these changes
Feb 1, 2023
|
Thank you for you work on this gentlemen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we discovered we do not properly handle broken tar archives.
The problem is running tar (in linting mode) on invalid archive and piping stdout to NSPipe introduces a hang as NSPipe cannot process such huge data amounts.
Fixing this problem by adding a precheck with tar (listing mode) with piping stdout to /dev/null.
Fixes: #4702