bump miniupnpc to 2.2.8

[Coeur]

bump miniupnpc from 2.2.7 to to 2.2.8

[Coeur]

When miniupnpc is 2.2.7 or older, UPNP_GetValidIGD requires exactly 5 arguments.
When miniupnpc is 2.2.8 or newer, UPNP_GetValidIGD requires exactly 7 arguments.
This is exactly the type of situations where they should have upgraded the Major version, or better, adopted a different method name. :/

[edit]
3523b92

[mikedld]

You seem to be referencing a commit that's not in our mirror (https://github.com/transmission/miniupnp), at least I'm not seeing a tag named miniupnpc_2_2_8 there, it'll need to be synced (including tags, I'd say) first. Could be that it works because GitHub transparently looks the commit up in the upstream repo, same way it works vice versa (referring to a commit in a fork repo through the upstream repo), but it doesn't mean it's the right thing to do because it's GitHub's magic / implementation details.

If we're currently referencing 2.2.7 (not sure when that happened), that's a good thing I noticed because if upstream would go away right now we'd have a broken repo.

[mikedld]

Ah, looks like we do have a commit matching 2.2.7 there after all, just not the tag :-\

[Coeur]

That has been discussed in the past: I offered Charles to have write access to the 3rd-party forks to sync them, but he preferred to do it himself whenever there are 3rd-party PR changes.

So I'm not doing it wrong: that's the current process:

1. We make a PR here on Transmission updating a 3rd-party
2. One of the 3 admins of Transmission syncs the forks
3. One of the 3 admins of Transmission merges the PR

And, well, in the extreme case where a 3rd-party would be erased from existence right after a release, I do have a local copy, since I test my changes before making pull requests, but I would question the validity of such release if the sources are no more official.

[mikedld]

I've synced all our 3rd-party mirrors (and set it up to sync periodically), so that should be resolved.

[tearfur]

Can't comment on the Xcode changes, but I'm happy with the other changes.

See if Mike wants the #if block extracted to a helper function instead.

[Coeur]

See if Mike wants the #if block extracted to a helper function instead.

I prefer not: for a single usage, I prefer avoiding wrappers.

Can't comment on the Xcode changes, but I'm happy with the other changes.

man ln for the doc about that function, ah ah. Basically, the option n is to help overwrite the symbolic link when changing the version of miniupnp.