publishCheckpoint returns the next publication time instead of the previous + nanoseconds for AWS#966
Merged
Merged
Conversation
AlCutter
approved these changes
May 21, 2026
| var pubAt time.Time | ||
| // Tessera used to store publishedAt in seconds, and now stores it in nanoseconds. | ||
| // This handles the transition. | ||
| const nanosecondThreshold = 1_310_324_790_000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #965.
This PR makes
publishCheckpointreturn the timestamp at which Tessera should try again to publish a checkpoint, instead of the last time that it successfully updated it. This allows better scheduling, especially when the tree doesn't grow.While we're here, also make the AWS implementation store the last publication timestamp in nanoseconds rather than seconds, like other implementation. This allows for sub-second scheduling.
This PR adds some test (contrary to #940). It checks that:
minStaleRepubis set to 0.