Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct order-of-magnitude error in raw data for T001 #40

Merged
merged 6 commits into from Nov 13, 2020
Merged

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Nov 13, 2020

Closes #32.

@khaeru khaeru added the historical Historical transport statistics label Nov 13, 2020
@khaeru khaeru self-assigned this Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #40 (32349be) into master (b73022e) will increase coverage by 0.43%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   52.09%   52.53%   +0.43%     
==========================================
  Files          35       35              
  Lines        1503     1521      +18     
==========================================
+ Hits          783      799      +16     
- Misses        720      722       +2     
Impacted Files Coverage Δ
item/historical/__init__.py 89.77% <40.00%> (-1.90%) ⬇️
item/historical/scripts/T000.py 100.00% <100.00%> (ø)
item/historical/scripts/T001.py 100.00% <100.00%> (ø)
item/historical/util.py 96.55% <100.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73022e...2c4fff7. Read the comment docs.

@khaeru khaeru merged commit 375683f into master Nov 13, 2020
@khaeru khaeru deleted the issue/32 branch November 13, 2020 18:23
@soniayeh
Copy link

soniayeh commented Feb 2, 2021

The fix was to multiply 100 to data 1985-2001. But I think the fix should be dividing 100 to data 2002 and after. Can you double check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
historical Historical transport statistics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T001: magnitude error in raw data for CHN
2 participants