Skip to content

Commit 8d500c9

Browse files
committed
Merge PR #285: Update span-stacktrace module to follow style guide
2 parents e3d1086 + 90a2939 commit 8d500c9

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceAutoConfig.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55

66
package io.opentelemetry.contrib.stacktrace;
77

8+
import static java.util.logging.Level.FINE;
9+
import static java.util.logging.Level.SEVERE;
10+
811
import com.google.auto.service.AutoService;
912
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizer;
1013
import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
@@ -19,7 +22,7 @@
1922
import javax.annotation.Nullable;
2023

2124
@AutoService(AutoConfigurationCustomizerProvider.class)
22-
public class StackTraceAutoConfig implements AutoConfigurationCustomizerProvider {
25+
public final class StackTraceAutoConfig implements AutoConfigurationCustomizerProvider {
2326

2427
private static final Logger log = Logger.getLogger(StackTraceAutoConfig.class.getName());
2528

@@ -50,7 +53,7 @@ static long getMinDuration(ConfigProperties properties) {
5053
log.fine("Stack traces capture is disabled");
5154
} else {
5255
log.log(
53-
Level.FINE,
56+
FINE,
5457
"Stack traces will be added to spans with a minimum duration of {0} nanos",
5558
minDuration);
5659
}
@@ -70,7 +73,7 @@ static Predicate<ReadableSpan> getFilterPredicate(ConfigProperties properties) {
7073

7174
if (filter == null) {
7275
// if value is set, lack of filtering is likely an error and must be reported
73-
Level disabledLogLevel = filterClass != null ? Level.SEVERE : Level.FINE;
76+
Level disabledLogLevel = filterClass != null ? SEVERE : FINE;
7477
log.log(disabledLogLevel, "Span stacktrace filtering disabled");
7578
return span -> true;
7679
} else {

span-stacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceSpanProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import java.io.StringWriter;
1515
import java.util.function.Predicate;
1616

17-
public class StackTraceSpanProcessor implements ExtendedSpanProcessor {
17+
public final class StackTraceSpanProcessor implements ExtendedSpanProcessor {
1818

1919
private final long minSpanDurationNanos;
2020

span-stacktrace/src/test/java/io/opentelemetry/contrib/stacktrace/StackTraceAutoConfigTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import java.util.function.Predicate;
1616
import org.junit.jupiter.api.Test;
1717

18-
public class StackTraceAutoConfigTest {
18+
class StackTraceAutoConfigTest {
1919

2020
@Test
2121
void defaultConfig() {

0 commit comments

Comments
 (0)