Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update haskell version example list to strings #1537

Merged
merged 2 commits into from Nov 7, 2017

Conversation

@iriberri
Copy link
Contributor

iriberri commented Nov 6, 2017

In YAML, - 7.10 would evaluate to version 7.1, and not 7.10.

I'm updating the examples here to use a list of strings instead. This comes from a specific request to update this for Haskell, but I assume is something we want to check in general, as this would affect other languages too.

@plaindocs

This comment has been minimized.

Copy link
Contributor

plaindocs commented Nov 7, 2017

Thanks @iriberri . Yeah, @BanzaiMan raised a similar issue recently, I've opened an issue to track the larger scale update.

@plaindocs plaindocs merged commit f6fee63 into master Nov 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@plaindocs plaindocs deleted the ci-haskell_string_versions branch Nov 7, 2017
@polyzen

This comment has been minimized.

Copy link

polyzen commented Nov 7, 2017

Why not quote when necessary instead of quoting all the things?

@iriberri

This comment has been minimized.

Copy link
Contributor Author

iriberri commented Nov 8, 2017

Hi @polyzen! That's a good point and of course that approach would work too :-) What I tried with this PR was to use strings in all the versions, since I thought that anyone taking those examples and expanding them for their use case would just imitate the quoting and therefore won't stumble into this issue.

This was however kind of a quick fix from a request - I definitely think that we need to document this in a more consistent way and also explain the limitation. We'll continue working on this as @plaindocs mentioned above :-)

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Nov 8, 2017

@polyzen In YAML, 7.8 is a float, "7.8" is a string. Software version numbers should be strings, not floats. We do not current document this consistently, but this PR is correct.

@polyzen polyzen referenced this pull request Nov 8, 2017
jdufresne added a commit to jdufresne/icalendar that referenced this pull request Nov 9, 2017
Per the feedback from @polyzen in PR collective#246, in YAML, numeric bare strings
are interpreted as floats, not strings. Versions are strings and should
not be coerced to a float. For example, 7.10 isn't the same as 7.1.

For more details, see Travis issue:

travis-ci/docs-travis-ci-com#1537
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Feb 8, 2018
Branch: refs/heads/master
Date: 2017-11-08T18:33:23-08:00
Author: Jon Dufresne (jdufresne) <jon.dufresne@gmail.com>
Commit: collective/icalendar@a33a357

Quote all version strings in Travis CI configuration

Per the feedback from @polyzen in PR #246, in YAML, numeric bare strings
are interpreted as floats, not strings. Versions are strings and should
not be coerced to a float. For example, 7.10 isn't the same as 7.1.

For more details, see Travis issue:

travis-ci/docs-travis-ci-com#1537

Files changed:
M .travis.yml
Repository: icalendar

Branch: refs/heads/master
Date: 2018-02-08T22:26:51+01:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: collective/icalendar@6eff2b0

Merge pull request #249 from jdufresne/quote-versions

Quote all version strings in Travis CI configuration

Files changed:
M .travis.yml
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Feb 8, 2018
Branch: refs/heads/master
Date: 2017-11-08T18:33:23-08:00
Author: Jon Dufresne (jdufresne) <jon.dufresne@gmail.com>
Commit: collective/icalendar@a33a357

Quote all version strings in Travis CI configuration

Per the feedback from @polyzen in PR #246, in YAML, numeric bare strings
are interpreted as floats, not strings. Versions are strings and should
not be coerced to a float. For example, 7.10 isn't the same as 7.1.

For more details, see Travis issue:

travis-ci/docs-travis-ci-com#1537

Files changed:
M .travis.yml
Repository: icalendar

Branch: refs/heads/master
Date: 2018-02-08T22:26:51+01:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: collective/icalendar@6eff2b0

Merge pull request #249 from jdufresne/quote-versions

Quote all version strings in Travis CI configuration

Files changed:
M .travis.yml
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Feb 8, 2018
Branch: refs/heads/master
Date: 2017-11-08T18:33:23-08:00
Author: Jon Dufresne (jdufresne) <jon.dufresne@gmail.com>
Commit: collective/icalendar@a33a357

Quote all version strings in Travis CI configuration

Per the feedback from @polyzen in PR #246, in YAML, numeric bare strings
are interpreted as floats, not strings. Versions are strings and should
not be coerced to a float. For example, 7.10 isn't the same as 7.1.

For more details, see Travis issue:

travis-ci/docs-travis-ci-com#1537

Files changed:
M .travis.yml
Repository: icalendar

Branch: refs/heads/master
Date: 2018-02-08T22:26:51+01:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: collective/icalendar@6eff2b0

Merge pull request #249 from jdufresne/quote-versions

Quote all version strings in Travis CI configuration

Files changed:
M .travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.