Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X: recommend the Travis Homebrew addon in the Homebrew section #2023

Merged
merged 3 commits into from Oct 23, 2018

Conversation

Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 18, 2018

@mjm suggested adding the Homebrew addon to the OS X documentation in #2017 (comment)

This pull request obsoletes #2017 and #2001.

@mjm
Copy link
Contributor

@mjm mjm commented Sep 18, 2018

Thanks for the PR, @teor2345!

I'm thinking that maybe we should take a stronger approach here. Instead of adding mentions of the addon around the existing instructions about manually installing packages, this could be an opportunity to clean up and simplify this page by removing a lot of that information, since the addon eliminates the need to worry about most of it.

If the "Homebrew" section of this page was just a short paragraph introducing and linking to the addon, I think we could eliminate most of these other headings completely, and that would make for clearer documentation. Can we give that a try?

@teor2345 teor2345 force-pushed the use-homebrew-addon branch from 910d687 to d97ce16 Oct 22, 2018
Summarise the important information about the Homebrew addon in
the OS X page, and link to the Homebrew addon reference.
@teor2345 teor2345 force-pushed the use-homebrew-addon branch from d97ce16 to 20af90e Oct 22, 2018
@teor2345
Copy link
Contributor Author

@teor2345 teor2345 commented Oct 23, 2018

If the "Homebrew" section of this page was just a short paragraph introducing and linking to the addon, I think we could eliminate most of these other headings completely, and that would make for clearer documentation. Can we give that a try?

Sure! Please see the updates I force-pushed to the pull request branch.

I'm not sure if you want to preserve the old heading anchors, or how to do that in markdown.

Copy link
Contributor

@plaindocs plaindocs left a comment

Unless the old headings break links, we can just delete them. Thanks.

@mjm
Copy link
Contributor

@mjm mjm commented Oct 23, 2018

This looks great to me! Thanks @teor2345!

@mjm mjm merged commit 9a8e4d9 into travis-ci:master Oct 23, 2018
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment