New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS Lambda documentation #974

Merged
merged 3 commits into from Feb 27, 2017

Conversation

Projects
None yet
2 participants
@martincostello
Copy link
Contributor

martincostello commented Feb 20, 2017

Update AWS Lambda documentation to be more likely to be correct for most users after I found the "minimal configuration to be insufficient when followed.

  1. The region value should be present (even though it is optional) as the majority of users worldwide probably aren't using us-east-1.
  2. Using a value of index.handler causes index.index.handler to be used instead, causing the lambda to fail. handler is sufficient.
  3. Add the runtime value and set to nodejs4.3 as nodejs is now deprecated and causes deployment to fail.

martincostello added some commits Feb 20, 2017

Update AWS Lambda documentation
Update AWS Lambda documentation to be more likely to be correct for most
users.
Update IAM policy
Add missing IAM roles to the policy document example.
@martincostello

This comment has been minimized.

Copy link
Contributor Author

martincostello commented Feb 20, 2017

Also updated the IAM policy JSON to include permissions for other functions used in the provider.

@plaindocs

This comment has been minimized.

Copy link
Contributor

plaindocs commented Feb 24, 2017

Hi @martincostello thanks for taking a good look at this!

Do you know if there is more generic runtime than nodejs4.3 as otherwise we'll have to update when that changes.

Is this "arn:aws:lambda:<region>:<account-id>:function:<name-of-function>" things that the user has to edit, or aws 'variables'?

@martincostello

This comment has been minimized.

Copy link
Contributor Author

martincostello commented Feb 24, 2017

@plaindocs Based on what I can see in the AWS Console for configuring lambda, there isn't a more generic runtime identifier:

image

I've used <thing> notation to mean a placeholder for the user's own values. Is there a different syntax you'd prefer?

@martincostello

This comment has been minimized.

Copy link
Contributor Author

martincostello commented Feb 24, 2017

(I was copying the format used in the example that was already there)

@plaindocs

This comment has been minimized.

Copy link
Contributor

plaindocs commented Feb 27, 2017

Hi @martincostello

Thanks for the reply. Fair point on the runtime!

I'm also aware you were just copying existing formatting, I'll merge this, and probably tweak the wording a little to clarify later.

Thanks again!

@plaindocs plaindocs merged commit c790b15 into travis-ci:gh-pages Feb 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martincostello martincostello deleted the martincostello:Update-AWS-Lambda branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment