Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build not playing well faraday version bump? #1108

Closed
NapsterInBlue opened this issue Sep 27, 2019 · 14 comments

Comments

@NapsterInBlue
Copy link

commented Sep 27, 2019

Hey all,

I keep a running gh-pages repo of technical notes that I've been building out for some time now.

Pushed a build yesterday that worked great, but revisiting it today, I've been getting emails warning about build failures

Examining, this happens at the final Installing deploy dependencies step and the only difference is that faraday got a version bump from 0.15.4 to 0.16.0, which looks brand-spankin' new as of today. Having trouble making heads or tails on the error message, though

Successfully installed multipart-post-2.1.1
Successfully installed faraday-0.16.0
Successfully installed public_suffix-3.0.3
Successfully installed addressable-2.7.0
Successfully installed sawyer-0.8.2
Successfully installed octokit-4.6.2
Successfully installed dpl-pages-1.10.12
7 gems installed
/home/travis/.rvm/gems/ruby-2.4.5/gems/octokit-4.6.2/lib/octokit/middleware/follow_redirects.rb:14:in `<module:Middleware>': uninitialized constant Faraday::Error::ClientError (NameError)
Did you mean?  Faraday::ClientError
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/octokit-4.6.2/lib/octokit/middleware/follow_redirects.rb:11:in `<module:Octokit>'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/octokit-4.6.2/lib/octokit/middleware/follow_redirects.rb:9:in `<top (required)>'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:59:in `require'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:59:in `require'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/octokit-4.6.2/lib/octokit/default.rb:1:in `<top (required)>'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:59:in `require'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:59:in `require'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/octokit-4.6.2/lib/octokit.rb:4:in `<top (required)>'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:59:in `require'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:59:in `require'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-pages-1.10.12/lib/dpl/provider/pages.rb:1:in `<top (required)>'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:135:in `require'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:135:in `rescue in require'
	from /home/travis/.rvm/rubies/ruby-2.4.5/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:39:in `require'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-1.10.12/lib/dpl/provider.rb:93:in `rescue in block in new'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-1.10.12/lib/dpl/provider.rb:68:in `block in new'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-1.10.12/lib/dpl/cli.rb:41:in `fold'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-1.10.12/lib/dpl/provider.rb:67:in `new'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-1.10.12/lib/dpl/cli.rb:31:in `run'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-1.10.12/lib/dpl/cli.rb:7:in `run'
	from /home/travis/.rvm/gems/ruby-2.4.5/gems/dpl-1.10.12/bin/dpl:5:in `<top (required)>'
	from /home/travis/.rvm/gems/ruby-2.4.5/bin/dpl:23:in `load'
	from /home/travis/.rvm/gems/ruby-2.4.5/bin/dpl:23:in `<main>'

Is this something I can resolve on my end?

Link to the simple travis.yml that kicks off the build

Thank you!

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

The error appears to be coming from Octokit's middleware.

octokit/octokit.rb#1154

@NapsterInBlue

This comment has been minimized.

Copy link
Author

commented Sep 27, 2019

Will keep an eye on this!

Thanks for such a quick response-- I'm thoroughly out of my depth here, haha

@liyasthomas

This comment has been minimized.

Copy link

commented Sep 27, 2019

Same here on my builds too. Deployment failing. Happened in last 1 or 2 hours. Before it was fine. Will keep an eye on here!

@ushis

This comment has been minimized.

Copy link

commented Sep 27, 2019

@BanzaiMan A temporary quick fix for dpl could be adding faraday <= 0.15.4 as dependency to the dpl-releases.gemspec until the issue is resolved in Octokit. Right?

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

@ushis yes. Alternatively, you can install faraday before deployment starts (to the Ruby that runs deployment), but that feels like a hack, to be honest.

BanzaiMan added a commit that referenced this issue Sep 27, 2019
So that Octokit 4.6.2 can coexist with it.

See #1108 and related issues
for more details.
@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

Hello, everyone.

I've released dpl-releases 1.10.13 and dpl-pages 1.10.13 to address this problem.

Please rerun the affected builds and report the results.

Thanks.

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

For completeness: lostisland/faraday#1030

@StevenRacz

This comment has been minimized.

Copy link

commented Sep 27, 2019

@BanzaiMan Fix is working for me. Thank you for the quick fix!

@NapsterInBlue

This comment has been minimized.

Copy link
Author

commented Sep 27, 2019

Same here! Huge thanks for taking the time to patch this :)

@ushis

This comment has been minimized.

Copy link

commented Sep 27, 2019

@BanzaiMan Works. Thx a lot!

@davide-romanini

This comment has been minimized.

Copy link

commented Sep 27, 2019

I'm using edge:true that uses dpl-2.0.0.alpha.7.gem and has the same problem.

@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

I'm inclined to wait for the upstream fixes for the edge. If it doesn't improve by early next week (say, Tuesday), we will consider amending it.

@liyasthomas

This comment has been minimized.

Copy link

commented Sep 27, 2019

Issue has been fixed

@svenfuchs

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

For v2 (edge) this had broken the end-to-end canary tests: https://travis-ci.com/travis-ci/dpl/builds/129558490 but has been fixed in the meantime: https://travis-ci.com/travis-ci/dpl/builds/129732505

I will assume this issue here can be closed. Please feel free to re-open it if needed.

@svenfuchs svenfuchs closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.