Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule files not included in Elastic Beanstalk upload #592

Closed
jdub opened this issue Mar 2, 2017 · 10 comments
Closed

Submodule files not included in Elastic Beanstalk upload #592

jdub opened this issue Mar 2, 2017 · 10 comments

Comments

@jdub
Copy link

jdub commented Mar 2, 2017

Probably worth adding --recurse-submodules to the git ls-files invocation.

@jdub jdub changed the title Submodule files not included in upload Submodule files not included in Elastic Beanstalk upload Mar 2, 2017
@jdub
Copy link
Author

jdub commented Mar 2, 2017

Here's a dirty workaround in the mean time. Won't work if your submodules have the same base path name.

- git submodule foreach 'cp -r . /tmp/$(basename $name) && cd $toplevel && git submodule deinit $path && git rm -rf $path && cp -r /tmp/$(basename $name)/ $path/ && git add $path/* $path/.??*'

@stale
Copy link

stale bot commented Apr 12, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Apr 12, 2018
@jdub
Copy link
Author

jdub commented Apr 13, 2018

This is still an ongoing issue.

@stale
Copy link

stale bot commented Jul 24, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Jul 24, 2018
@jdub
Copy link
Author

jdub commented Jul 24, 2018

This is still an ongoing issue.

@stale stale bot removed the stale label Jul 24, 2018
@atwalsh
Copy link

atwalsh commented Jul 30, 2018

Also having this issue.

@jdub
Copy link
Author

jdub commented Aug 3, 2018

btw, I made PR #593 the day I reported this. 😄

@BanzaiMan
Copy link
Contributor

Please test the PR. Thanks.

@ashenm
Copy link
Contributor

ashenm commented Jun 6, 2019

#593 (comment)

@svenfuchs
Copy link
Contributor

I believe this issue is addressed in master by the way of not using git ls-files any more. See now 52032f9#diff-ac0853c6afef4a5351a9251c31910ec8

I'm going to close this issue here. Please feel free to re-open if needed, or make a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants