New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using heroku build result endpoint #917

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
4 participants
@dmathieu
Contributor

dmathieu commented Nov 12, 2018

This endpoint has been deprecated for years, and we are looking into removing it.
As such, it is currently browned out and will be permanently removed in 2 weeks.
See https://devcenter.heroku.com/changelog-items/1486

This PR stops using that endpoint, to use the standard build one.

@dmathieu dmathieu referenced this pull request Nov 12, 2018

Closed

Fix heroku result #919

@cotsog

This comment has been minimized.

Contributor

cotsog commented Nov 12, 2018

@dmathieu Thank you so much for proactively letting us know about this and coming up with the fix at the same time.

To validate your solution, do you think it would be possible for you (or someone else following this PR) to run a test deployment with the following in the .travis.yml file?

deploy:
  provider: heroku
  edge:
    source: dmathieu/dpl
    branch: heroku-result
  

Thanks in advance!

@dmathieu

This comment has been minimized.

Contributor

dmathieu commented Nov 12, 2018

I can do that tomorrow. If someone wants to do it before, happy to take that too.

@cotsog

This comment has been minimized.

Contributor

cotsog commented Nov 12, 2018

I tested it on one of our repos: https://travis-ci.org/travis-ci/docs-travis-ci-com/builds/454121385. It works!

@cotsog cotsog merged commit d588bd0 into travis-ci:master Nov 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cotsog

This comment has been minimized.

Contributor

cotsog commented Nov 12, 2018

We'll get the dpl version updated tomorrow, probably. In the meantime, you can use the following in your .travis.yml file to get the fix:

deploy:
  provider: heroku
  edge: true

Thank you for your patience!

@ctreptow

This comment has been minimized.

ctreptow commented Nov 12, 2018

It also worked on three of our repos.

@cotsog

This comment has been minimized.

Contributor

cotsog commented Nov 12, 2018

New dpl version with this fix has now been released.

Please let us know if you are still having issues.

Thanks again everyone!

@plaindocs

This comment has been minimized.

Contributor

plaindocs commented Nov 13, 2018

Thanks for the quick work folks! @dmathieu @cotsog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment