New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a custom user-agent for all heroku API calls #931

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@dmathieu
Copy link
Contributor

dmathieu commented Nov 28, 2018

When deprecating the build result endpoint, we didn't see dpl was still using that endpoint due to the lack of custom User Agent, which led us to fix it a bit late (#917).

This sets a custom user agent, to prevent this kind of issue from happening again.

set a customer user-agent for all heroku API calls
When deprecating the build result endpoint, we didn't see dpl was still
using that endpoint due to the lack of custom User Agent, which led us
to fix it a bit late (#917).
@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Nov 28, 2018

@dmathieu Thanks for the PR. Has this been tested and confirmed on your end?

@BanzaiMan BanzaiMan self-assigned this Nov 28, 2018

@BanzaiMan BanzaiMan added this to the v1.10.7 milestone Nov 28, 2018

@dmathieu

This comment has been minimized.

Copy link
Contributor Author

dmathieu commented Nov 28, 2018

I haven't tested it on an actual app, and I don't have any repository using Travis as a deployment method. I can set that up tomorrow.

@dmathieu dmathieu changed the title Set a customer user-agent for all heroku API calls Set a custom user-agent for all heroku API calls Nov 28, 2018

@BanzaiMan

This comment has been minimized.

Copy link
Member

BanzaiMan commented Nov 28, 2018

@dmathieu That'll be great. Thanks again!

@dmathieu

This comment has been minimized.

Copy link
Contributor Author

dmathieu commented Nov 29, 2018

I have successfully tested this branch: https://travis-ci.com/dmathieu/foobar/builds/92969247
And I confirm from Heroku's end that we do receive requests with the proper user agent (travis/0.1.0 dpl/1.10.6).

@BanzaiMan BanzaiMan merged commit 6cb52e2 into travis-ci:master Nov 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment