Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mime-types gem #984

Merged

Conversation

Projects
None yet
2 participants
@jonstites
Copy link
Contributor

commented Apr 8, 2019

The Github Releases, AWS S3, and Google Cloud Storage providers use the mime-types gem 2.x. This PR changes them to use mime-types gem 3.x.

The mime-types gem 2.x was no longer supported as of 2017-11-21.

This means that new mime-types added in mime-types 3.x are not being uploaded with the correct Content-Type.

This solves my particular problem of webassembly files not having the correct Content-Type on AWS S3, but hopefully it makes life a little easier for other users too at some point.

rake spec-releases spec-gcs spec-s3 shows no failures, and I have a working deployment using my fork: https://travis-ci.com/jonstites/game_of_life/jobs/191123300

@BanzaiMan BanzaiMan merged commit db29420 into travis-ci:master Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BanzaiMan

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.