New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build precise docker images on top of "standard" docker images #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and stub in an empty metadata tarball to appease the artifacts upload.
and rename commands file used by other precise stacks
meatballhat
requested review from
solarce,
sarahhodne,
Lyoness,
emdantrim and
igorwwwwwwwwwwwwwwwwwwww
January 9, 2017 19:47
1 task
sarahhodne
approved these changes
Jan 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with all our Chef stuff, but this all makes sense to me.
emdantrim
approved these changes
Jan 10, 2017
dwijnand
reviewed
Jan 24, 2017
include_recipe 'sbt-extras' | ||
# FIXME: sbt-extras installation currently busted due to incompatibility | ||
# something something https://github.com/travis-ci/travis-build/pull/701 | ||
# include_recipe 'sbt-extras' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will mean that precise images are layered in much the same way that they were in the elder travis-images build system such that a "standard" layer is baked and published, with language-specific images built on top of them. The reasoning for this change is that with the current system of per-language images built from a common base of
travisci/ubuntu-upstart:12.04
, the time to in-service can sometimes take more than an hour as opposed to the ~15-20m when the shared base is something higher up the stack.notable stuff
sbt-extras
is currently disabled on thejava-precise
stack due to a compatibility issue with sbt version(s)