replace ember.js with ember-rails gem #1

Closed
ttdonovan opened this Issue Apr 19, 2012 · 10 comments

4 participants

@ttdonovan

I've forked the repo and am attempting to replace the vendor/ember.js with the ember-rails gem. The branch is a work in progress but I've run into issues with the application.js.

//= require ember

The travis-ci asset-host branch returns a "Sprockets::FileNotFound in Home#index couldn't find file 'ember'".

Any help or insight would greatly be appreciated.

https://github.com/ttdonovan/travis-assets/compare/ember-rails-gem

Note Ember.js 0.9.6 has a XSS vulnerability and 0.9.7 has a fix.

emberjs/ember.js@255bd70

@tchak

Not sure what you missed, but I made a new pr for this #2

@tchak

Hmm, looks like you right, there is something wrong with assets paths when loading engine in travis-ci app

@tchak

The problem is travis-assets is not a real rails engine, so it will not add assets of required gems to assets path by it self.

@svenfuchs would it be a problem to declare a full engine so we can load assets files from other gems (engines) or is there a good reason to not to?

@tchak

Nop, engine dose not help... I have no more ideas for the moment :)

@ttdonovan

@tchak Thanks for looking into the issue. Not sure if this helps or not, but when I a rake precompile:assets in travis-assets I am experiencing the same error.

$ rake assets:precompile
/Users/tanner/.rvm/rubies/ruby-1.9.2-p290/bin/ruby /Users/tanner/.rvm/gems/ruby-1.9.2-p290@travis-ci/bin/rake assets:precompile:all RAILS_ENV=production RAILS_GROUPS=assets
rake aborted!
couldn't find file 'ember'
  (in /Users/tanner/code/personal/ttdonovan-github/travis-assets/app/assets/javascripts/application.js:1)

Tasks: TOP => assets:precompile:primary
(See full trace by running task with --trace)
rake aborted!
Command failed with status (1): [/Users/tanner/.rvm/rubies/ruby-1.9.2-p290/...]

Tasks: TOP => assets:precompile
(See full trace by running task with --trace)
@svenfuchs
Travis CI member
@ttdonovan

@svenfuchs just for my understanding and clarity, the purpose of this engine/app is to serve the static front-end assets for the travis-ci. My understanding of this project is that all future JavaScript and CSS development and testing happens in the travis-assets repo and at some point those assets will be removed from the travis-ci repo. Example: Any changes or enhancements to the Ember.js app occur here with either the Jasmine or JUnit tests (not sure if any exists in the travis-ci).
To do front-end development/integration testing both the travis-ci and travis-assets will need to running.

@svenfuchs
Travis CI member
@henrikhodne
Travis CI member

@svenfuchs I'm guessing this got fixed somehow, since travis-assets is in production now?

@svenfuchs
Travis CI member

yeah, i guess so. closing this. thx :)

@svenfuchs svenfuchs closed this May 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment