Explicitly specify 1.8 when installing jruby-18mode #10

Merged
merged 2 commits into from Dec 12, 2012

Projects

None yet

2 participants

@ecoffey

Noticed this when running a build for resque

https://travis-ci.org/defunkt/resque/jobs/3498628

$ rvm use jruby-18mode
$ ruby --version
jruby 1.7.0 (1.9.3p203) 2012-10-22 ff1ebbe on Java HotSpot(TM) Server VM 1.7.0_09-b05 [linux-i386]

The default for rvm 1.17 when installing jruby is to build as 1.9.3.

This change just explicitly uses --18 when installing jruby and renames it jruby-d18.

@joshk
Travis CI member

this means that jruby is no longer installed and available.

the change is close to what is needed but is not quite there.

instead you need to alias d19 to jruby and install jruby in 1.8 mode as well

@joshk
Travis CI member

i have this fixed in a branch which i am using for testing on our new vm setup, sorry for not backporting this, redeploying vm images is very painful right now

@ecoffey

No problem :-)

Just something I noticed and thought I could help with.

@joshk
Travis CI member
@ecoffey

Just pushed the alias change, so either this or the backport would work :-)

Sometimes OSS is just all about that gentle nudge :D

@joshk
Travis CI member

@ecoffey have you seen the PR I sent you? :)

@ecoffey

@joshk saw it after I pushed :-)

Not to shave the yak.....but I kind of feel like explicitly stating what versions we want of jruby and then explicitly pointing the default at the version we want is more clear; and avoids the original issue (the changing of defaults).

But in the grand scheme it's six of one, half dozen of the other!

@joshk
Travis CI member
@ecoffey

Just booted another VM with the config from this PR using

thor travis:box:build ruby

and rvm was more than happy to alias create jruby jruby-19mode, and a rvm use jruby ran fine.

Not sure how to do a more integration style test on my local machine.

If that's good confirmation for you I say :shipit:

:metal:

@ecoffey

bump :-)

@joshk joshk merged commit d80952b into travis-ci:master Dec 12, 2012

1 check passed

Details default The Travis build passed
@ecoffey

Thanks!

@joshk
Travis CI member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment