Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to install scripts #104

Merged
merged 1 commit into from May 18, 2013

Conversation

Projects
None yet
3 participants
@sarahhodne
Copy link
Contributor

commented May 17, 2013

This'll retry install script three times before actually failing. Useful if there are network timeouts or similar issues (see travis-ci/travis-ci#1089 and travis-ci/travis-ci#1077).

Add retries to install scripts
This'll retry install script three times before actually failing. Useful
if there are network timeouts or similar issues (see #1089 and #1077).
@@ -18,7 +18,7 @@ def setup
end

def install
uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install'
uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install', retry: true

This comment has been minimized.

Copy link
@sarahhodne

sarahhodne May 17, 2013

Author Contributor

This might end up not doing exactly what we want (the retry only picks up the go get, not the go build, due to the &&).

This comment has been minimized.

Copy link
@joshk

joshk May 18, 2013

Member

are you saying that only the go get is retried? If that is the case then this is correct as go get is the only thing which does TCP connections.

This comment has been minimized.

Copy link
@sarahhodne

sarahhodne May 18, 2013

Author Contributor

Correct, that is what happens. See the generated build script:

travis_retry go get -d -v ./... && go build -v ./...

This comment has been minimized.

Copy link
@joshk

joshk May 18, 2013

Member

Yep, it is a little deceptive, but I guess it works, maybe add a little doc line about it just so we know for the future.

On 18/05/2013, at 10:23 AM, Henrik Hodne notifications@github.com wrote:

In lib/travis/build/script/go.rb:

@@ -18,7 +18,7 @@ def setup
end

     def install
  •      uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install'
    
  •      uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install', retry: true
    
    Correct, that is what happens. See the generated build script:

travis_retry go get -d -v ./... && go build -v ./...

Reply to this email directly or view it on GitHub.

@roidrage

This comment has been minimized.

Copy link
Contributor

commented May 18, 2013

❤️ ❤️ ❤️

sarahhodne added a commit that referenced this pull request May 18, 2013

Merge pull request #104 from travis-ci/hh-add-retry
Add retries to install scripts

@sarahhodne sarahhodne merged commit 9dc94a1 into master May 18, 2013

1 check passed

default The Travis CI build passed
Details

@sarahhodne sarahhodne deleted the hh-add-retry branch May 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.