Dynamic config #14

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

I don't want this to be merge but i'd like it be reviewed to know if the tests i wrote correspond to what we expect:
read the timeouts from the build payload if they are present.

Owner

joshk commented Mar 30, 2012

Just so I can make sure I understand, do we have hard defaults we make sure users can not exceed?

eg. a users says a script can have a timeout of 5 hours but we trim that to 1 hour, which is the max

This is not included yet. What should be the max values ? The default ones ?

Owner

joshk commented Mar 30, 2012

I think we need two ideas encapsulated in this PR.

The first is a 'default' set of timeouts eg. 5 mins for install, 20 mins for script

The second is a max custom timeout eg. if a project says 'please use my 5 hour timeout' the worker should say 'nice try but i am only going to allow for a 1 hour max'

The reason for the max is because if a project screws up and enters a way too big timeout but then hangs and also triggers lots of builds then the worker queue could be eaten up for ever requiring us to intervene.

Let me know what you think about these ideas.

J

Owner

svenfuchs commented Apr 2, 2012

i'd like to see a first "trusted" user to define a 5 hours timeout and actually use it. once this happens we can kill him from the whitelist, blame him on twitter and improve the feature.

Owner

joshk commented Apr 2, 2012

I don't care anymore.

On 2/04/2012, at 4:24 PM, Sven Fuchs wrote:

i'd like to see a first "trusted" user to define a 5 hours timeout and actually use it. once this happens we can kill him from the whitelist, blame him on twitter and improve the feature.


Reply to this email directly or view it on GitHub:
#14 (comment)

Owner

rkh commented Apr 2, 2012

group hug

Owner

svenfuchs commented Apr 11, 2012

Having looked over this with @lucaspinto yesterday we found this needs to be solved differently. Looking into it.

kykim commented Jul 26, 2012

what's the status on this?

Owner

joshk commented May 6, 2013

Closing as this PR is stale and so much has changed. Thanks for giving this a crack @lucaspinto, super high 5!

@joshk joshk closed this May 6, 2013

@joshk joshk deleted the dynamic_config branch Oct 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment