Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.rb: skip brew update if disable_homebrew = true #1874

Merged
merged 1 commit into from Mar 19, 2020

Conversation

@jeroen
Copy link
Contributor

jeroen commented Mar 14, 2020

With the latest versions of homebrew, brew update fails on legacy MacOS. But on these legacy systems we still want to be able to test without homebrew.

Example: https://travis-ci.org/github/r-dbi/RMySQL/jobs/662231478?utm_medium=notification&utm_source=github_status

@jimhester

@jimhester

This comment has been minimized.

Copy link
Contributor

jimhester commented Mar 14, 2020

LGTM

@jeroen jeroen force-pushed the jeroen:patch-1 branch from 8f4261b to b0884d1 Mar 14, 2020
@jeroen

This comment has been minimized.

Copy link
Contributor Author

jeroen commented Mar 14, 2020

@BanzaiMan Can we merge this? Thanks!

@jeroen

This comment has been minimized.

Copy link
Contributor Author

jeroen commented Mar 19, 2020

@weban @BanzaiMan please? thanks! ❤️ 🚀

@BanzaiMan BanzaiMan merged commit beca06c into travis-ci:master Mar 19, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@jeroen jeroen deleted the jeroen:patch-1 branch Mar 19, 2020
@jeroen

This comment has been minimized.

Copy link
Contributor Author

jeroen commented Mar 20, 2020

Hmm has this been deployed? It doesn't have any effect yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.