Set TRAVIS_CMD explicitely, stop using the DEBUG trap #272

Closed
wants to merge 3 commits into
from

2 participants

@svenfuchs
Travis CI member

Motivated by the fact that #199 stopped considering simpler solutions because of the DEBUG trap messing with them.

@joshk
Travis CI member

looks good to me, although I'm not entirely sure if this works :)

can you create a branch on worker and deploy this to staging for testing?

@drogus drogus commented on the diff Jul 22, 2014
lib/travis/build/script.rb
@@ -76,7 +76,7 @@ def check_config
true
when 'server_error'
cmd 'echo -e "\033[31;1mCould not fetch .travis.yml from GitHub.\033[0m"', assert: false, echo: false
- cmd 'travis_terminate 2', assert: false, echo: false
+ raw 'travis_terminate 2', assert: false, echo: false
@drogus
Travis CI member
drogus added a line comment Jul 22, 2014

What's the difference between these 2 versions?

@svenfuchs
Travis CI member
svenfuchs added a line comment Jul 22, 2014

@drogus basically, raw inserts a Node, while cmd inserts a Cmd instance. I guess the options assert: false, echo: false could be removed from that line.

@joshk
Travis CI member
joshk added a line comment Jul 28, 2014

should we remove the assert and echo now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@joshk
Travis CI member

is this safe to merge in? has it been tested on staging?

@svenfuchs svenfuchs closed this Jul 29, 2014
@BanzaiMan BanzaiMan deleted the sf-remove_travis_cmd_trap branch Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment