New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `./node_modules/.bin` from $PATH #903

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@BanzaiMan
Member

BanzaiMan commented Dec 6, 2016

Some npm modules define commands with widely used bash functions
(and probably others).
Putting this component in $PATH causes subtle issues, such as
travis-ci/travis-ci#5092.
We are removing it, so that this is no longer the case.

This will most likely break some builds, so we add a warning.

Remvoe `./node_modules/bin` from $PATH
Some npm modules define commands with widely used bash functions
(and probably others).
Putting this component in `$PATH` causes subtle issues, such as
travis-ci/travis-ci#5092.
We are removing it, so that this is no longer the case.

This will most likely break some builds, so we add a warning.

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@BanzaiMan BanzaiMan changed the title from Remvoe `./node_modules/bin` from $PATH to Remvoe `./node_modules/.bin` from $PATH Dec 6, 2016

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@nathanhammond

This comment has been minimized.

nathanhammond commented Dec 6, 2016

Note that, to my knowledge, this change breaks every Ember addon out there because of our default blueprint: https://github.com/ember-cli/ember-cli/blob/74562a4/blueprints/addon/files/.travis.yml#L40

@backspace

This comment has been minimized.

Member

backspace commented Dec 6, 2016

This will break things for almost all Ember projects, as ember test is the default way to run tests and that assumes the Node-installed ember command is available.

@nathanhammond

This comment has been minimized.

nathanhammond commented Dec 6, 2016

This doesn't appear to have landed yet we currently have reported failures from users in our Slack channel. Also, hi, @backspace! <3

@joshk

This comment has been minimized.

Member

joshk commented Dec 6, 2016

I'm not sure I support this change. This will cause major issues for many people using Node.

@Turbo87

This comment has been minimized.

Turbo87 commented Dec 6, 2016

@BanzaiMan instead of removing the path completely, would it maybe be possible to move it to the end of the list as a fallback? that way the native executables are preferred, but the Ember addon builds won't fail.

@BanzaiMan

This comment has been minimized.

Member

BanzaiMan commented Dec 6, 2016

The offending bit is travis-ci/travis-cookbooks#786, which renders this PR obsolete. I'll work on a fix for the issue shortly.

@meatballhat meatballhat changed the title from Remvoe `./node_modules/.bin` from $PATH to Remove `./node_modules/.bin` from $PATH Dec 6, 2016

@mc10

This comment has been minimized.

Contributor

mc10 commented Jan 11, 2017

Since this PR is now obsolete, it can be closed now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment