New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ./node_modules/.bin to $PATH #905

Merged
merged 2 commits into from Dec 6, 2016

Conversation

Projects
None yet
4 participants
@BanzaiMan
Member

BanzaiMan commented Dec 6, 2016

travis-ci/travis-cookbooks#786 removed it, but
this broke many Ember-based repositories, so we will reinstate it.

This is meant to be a hot fix, which would be reverted after a new set
of build images are rolled out.

@backspace

This comment has been minimized.

Member

backspace commented Dec 6, 2016

Someone suggested appending instead of prepending, would that be better to address the reason for this?

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@BanzaiMan

This comment has been minimized.

Member

BanzaiMan commented Dec 6, 2016

@backspace I don't think that'll work, because which is a Bash built-in function, and it's not on $PATH. That issue must be addressed separately.

@Turbo87

This comment has been minimized.

Turbo87 commented Dec 6, 2016

@BanzaiMan right, that makes sense, thanks!

Add ./node_modules/.bin to $PATH
travis-ci/travis-cookbooks#786 removed it, but
this broke many Ember-based repositories, so we will reinstate it.

This is meant to be a hot fix, which would be reverted after a new set
of build images are rolled out.

@BanzaiMan BanzaiMan force-pushed the ha-node-js-path-fix branch from 4853d1b to ad811ed Dec 6, 2016

@BanzaiMan BanzaiMan deployed to org-staging Dec 6, 2016 Active

@BanzaiMan BanzaiMan deployed to org-production Dec 6, 2016 Active

@BanzaiMan BanzaiMan merged commit 524f3d8 into master Dec 6, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@BanzaiMan BanzaiMan deleted the ha-node-js-path-fix branch Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment