New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on: tags condition for deploys still not working #1675
Comments
Same here, build #1760932 on travis pro. |
@rkh: I think this has been fixed now Can you still reproduce this? |
Still does not work for me, build #1787204 on travis pro. |
@rkh: I believe that I have (finally) fixed it. Can you confirm this? |
Still nothing happens (no log output) if I add on: tags: true to my .travis.yml. Build #1993648 on travis pro. |
@rkh @henrikhodne: What version of travis-build is deployed on travis-cicom? |
The newest versions of travis-build are deployed, but we're still getting reports of this not working unfortunately. |
I can give it another go on my repos today and report back. |
Nope, still does not work. Travis Pro, build #2703379, python 2.7, deploying on PyPI. Works fine until I add "on: tags: true", then the only output for the deploy step is this:
|
As I wrote in duplicated issue "on" crashes http://lint.travis-ci.org/ (and my lint too). I suppose there will not be a problem to reproduce error for authors. |
|
That's a bug in travis-lint. |
I can't find deploy (to PyPi) which falls when I use on: tags: true. But possible it was the same error. I'll try to reproduce. |
Yeah, still not working for me. Trying to deploy to RubyGems with |
Hey guys, sorry for the delays. I’m currently looking into this issue, will report back with my findings early next week. |
- NOTE: must set branch condition, but there is a bug in travis causing it not to work: travis-ci/travis-ci#1675
- Travis deploy is not working see travis-ci/travis-ci#1675
I’ve dug a bit deeper into this issue. The problem goes a bit further than I originally thought, but I think I at least found a workaround for the time being. The issue is that, by default, we include an implicit branch condition when checking the So the issue is that we actually set $TRAVIS_BRANCH to the tag’s name, and that we have an implicit branch condition in there, that’s not properly documented. The temporary fix is to add deploy:
on:
tags: true
all_branches: true I’ll make sure to add this to our documentation. This relates to #1670. |
@roidrage Your workaround will trigger two deployments, one for branch master on a tag, and one for the tag, which can cause problems when deploying things as Travis tries to deploy them twice. |
Are you sure? Have you tried it? |
I discovered a workaround for deploying to AWS (and by "discovered", I mean stole from the CloudFoundry wiki:
A little bit more manual labor here, but it works like a charm. It probably won't work for all deployment types, but I hope it helps some of you. |
Adding |
More info here: travis-ci/travis-ci#1675
The following might be a work around for the multiple deploy problem. I'm using it in a custom deployment setup.
I haven't tried it with the travis deploy config, but the docs say you can use your own condition. So the above snippet could be condensed to one line, or put in a script. The reference I saw to the custom conditions was the |
Workaround for: travis-ci/travis-ci#1675
Still requires |
Hello, kids! I believe I fixed this with travis-ci/travis-build@28c1b85. This has been deployed. Please test this on your repository. (It worked on my tests, but it might have left some stones unturned.) Thank you! |
travis-ci/travis-ci#1675 has been fixed, so we need to document how this condition is expected to behave.
Thanks. It works on my test repo. |
I'm glad that this issue is finally resolved. |
Is there now a way to prevent that accidental tags on any branch other than master create a release? |
Hi, still not working for me with PyPi on mrtazz/simplenote.py (I'm a
maintainer). Just tried two tagged commits (one lightweight 183221a
and one annotated 600595f in case it matters) and Travis is reporting
"Skipping deployment with the pypi provider because this is not a
tagged commit".
It could well be something I'm doing wrong, but I'm stumped as to
what.
I notice via 'travis requests' I do have a couple of builds that say
"received (validation pending)" if that means anything?
|
@atomicules Neither https://travis-ci.org/mrtazz/simplenote.py/builds/50820565 nor https://travis-ci.org/mrtazz/simplenote.py/builds/50827064 is a tagged build. You are only building the See also https://travis-ci.org/mrtazz/simplenote.py/requests |
Hoping this is the fix based on this advice: travis-ci/travis-ci#1675 (comment) References #10
@BanzaiMan thank you for pointing that out to me. I have fixed that
and it is now trying to deploy now, but failing with:
"invalid option "--password=""
|
@atomicules Sounds like your encrypted password was not decrypted correctly. Please review the documentation. |
@BanzaiMan we re-added the password and deploys are now working. Thank you very much for your responses. |
travis-ci/travis-ci#1675 was recently fixed
travis-ci/travis-ci#1675 has been fixed
@vaibhavsagar Looks like the same mistake I made. Remove these lines and try it again. |
That worked! Thanks so much @atomicules! |
I'm just getting started with travis and npm deployments and I am having trouble getting travis to push to npmjs.com on tagged commits, seeing the same behavior as described in this ticket. Hopefully someone can point out something obvious that I'm missing. Result: I added "all_branches: true" per the workaround instructions in this issue. My process for committing / pushing was
Thanks in advance for any direction or advice you might be able to provide. |
@chrisbaldauf Sorry to hear about this issue. I think it's a separate issue, though, so please open a new issue. |
rkh commentedNov 26, 2013
No description provided.
The text was updated successfully, but these errors were encountered: