New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build duration, not recency, wrongly affects current pass/fail status #2436

Closed
tjwebb opened this Issue Jun 17, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@tjwebb

tjwebb commented Jun 17, 2014

Build 327 is more recent than build 326, but since 326 finished after 327, the current status of my build is "Failing" even though the most recent build passes. I think the headline build status should be determined by the success/failure of the most recent numbered build.

tci-build-timing-fail

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Jun 17, 2014

Member

I don't think that is the case here. The status is set to "failing" because temporally latest (build 326) failed. I believe this is a duplicate of #483. Let us know if you disagree.

Member

BanzaiMan commented Jun 17, 2014

I don't think that is the case here. The status is set to "failing" because temporally latest (build 326) failed. I believe this is a duplicate of #483. Let us know if you disagree.

@BanzaiMan BanzaiMan closed this Jun 17, 2014

@tjwebb

This comment has been minimized.

Show comment
Hide comment
@tjwebb

tjwebb Jun 17, 2014

From #483:

Note that the build-status image shows the correct status.

The difference between this and #483 is that my build-status image shows it failing. 327 has finished successfully, which is the current build, so Travis-CI should not say it failed anywhere except for the 326 line-item in the build history. Current build status should be "Passing", categorically.

tjwebb commented Jun 17, 2014

From #483:

Note that the build-status image shows the correct status.

The difference between this and #483 is that my build-status image shows it failing. 327 has finished successfully, which is the current build, so Travis-CI should not say it failed anywhere except for the 326 line-item in the build history. Current build status should be "Passing", categorically.

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Jun 17, 2014

Member

Build 327 is not the current build, because 326 finished later.

Member

BanzaiMan commented Jun 17, 2014

Build 327 is not the current build, because 326 finished later.

@tjwebb

This comment has been minimized.

Show comment
Hide comment
@tjwebb

tjwebb Jun 17, 2014

327 is my most up-to-date code. I made efficiency improvements in 327 build that makes it run faster than 326. You're saying that that fact that 326 is slower means that it becomes the "current" build since it takes longer? The code in 326 is older, so it by definition 326 cannot be the more current than 327. Therefore the current status should be based on the most recent code (327), not the most recent completion (326). Help me understand this.

tjwebb commented Jun 17, 2014

327 is my most up-to-date code. I made efficiency improvements in 327 build that makes it run faster than 326. You're saying that that fact that 326 is slower means that it becomes the "current" build since it takes longer? The code in 326 is older, so it by definition 326 cannot be the more current than 327. Therefore the current status should be based on the most recent code (327), not the most recent completion (326). Help me understand this.

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Jun 17, 2014

Member

I'm saying that there is a bug, in that our idea of "current" is unexpected. As of now, it is defined as the "build that finished most recently", which is in one sense (I indicated this as "temporally" in the initial comment) correct, but not what most people (including you and me) expect.

Member

BanzaiMan commented Jun 17, 2014

I'm saying that there is a bug, in that our idea of "current" is unexpected. As of now, it is defined as the "build that finished most recently", which is in one sense (I indicated this as "temporally" in the initial comment) correct, but not what most people (including you and me) expect.

@tjwebb

This comment has been minimized.

Show comment
Hide comment
@tjwebb

tjwebb Jun 18, 2014

Gotcha, thanks for clarifying. I'll follow #483.

btw @BanzaiMan see you in December: norfolkjs/logistics#39

tjwebb commented Jun 18, 2014

Gotcha, thanks for clarifying. I'll follow #483.

btw @BanzaiMan see you in December: norfolkjs/logistics#39

@BanzaiMan

This comment has been minimized.

Show comment
Hide comment
@BanzaiMan

BanzaiMan Jun 18, 2014

Member

@tjwebb Awesome! Looking forward to it.

Member

BanzaiMan commented Jun 18, 2014

@tjwebb Awesome! Looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment